Linux syscollector: retrieve MAC addresses from "/sys/class/net/<ifname>/address". #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikman90
requested changes
Feb 10, 2019
There was a problem hiding this comment.
@DarkMatterCore thanks for this PR.
However, the interface's MAC address does not appear in the database:
$ sqlite3 /var/ossec/queue/db/000.db "select name,mac from sys_netiface;"
enp0s8|
enp0s3|And Syscollector displays those errors:
2019/02/09 20:10:22 wazuh-modulesd:syscollector[3615] syscollector_linux.c:1078 at sys_network_linux(): ERROR: Invalid MAC address length for interface "enp0s8" at "/sys/class/net/enp0s8/address".
2019/02/09 20:10:22 wazuh-modulesd:syscollector[3615] syscollector_linux.c:1078 at sys_network_linux(): ERROR: Invalid MAC address length for interface "enp0s8" at "/sys/class/net/enp0s8/address".
2019/02/09 20:10:22 wazuh-modulesd:syscollector[3615] syscollector_linux.c:1078 at sys_network_linux(): ERROR: Invalid MAC address length for interface "enp0s8" at "/sys/class/net/enp0s8/address".
2019/02/09 20:10:22 wazuh-modulesd:syscollector[3615] syscollector_linux.c:1078 at sys_network_linux(): ERROR: Invalid MAC address length for interface "enp0s3" at "/sys/class/net/enp0s3/address".
2019/02/09 20:10:22 wazuh-modulesd:syscollector[3615] syscollector_linux.c:1078 at sys_network_linux(): ERROR: Invalid MAC address length for interface "enp0s3" at "/sys/class/net/enp0s3/address".
2019/02/09 20:10:22 wazuh-modulesd:syscollector[3615] syscollector_linux.c:1078 at sys_network_linux(): ERROR: Invalid MAC address length for interface "enp0s3" at "/sys/class/net/enp0s3/address".
Please consider the fix described.
I confirm that this PR with that patch gets the MAC address on:
- CentOS 6 (VM on Vagrant)
- CentOS 7 (VM on Vagrant)
- Ubuntu 18.10 (VM on Vagrant)
- Debian 9 on Raspberry Pi 3.
Thank you.
Best.
vikman90
approved these changes
Feb 10, 2019
vikman90
requested changes
Feb 10, 2019
There was a problem hiding this comment.
This error appears in CentOS 5:
2019/02/10 20:09:52 wazuh-modulesd:syscollector: ERROR: Invalid MAC address length for interface "sit0" at "/sys/class/net/sit0/address".
In fact, the simple internet transition interface has no MAC address;
$ ip addr show sit0
4: sit0: <NOARP> mtu 1480 qdisc noop
link/sit 0.0.0.0 brd 0.0.0.0This condition should not produce an error but a debug log.
In fact, the system file exists but it has a shorter zero-filled MAC address:
$ cat /sys/class/net/sit0/address
00:00:00:00
Some tunneling interfaces have a shorter MAC, like "00:00:00:00"
vikman90
approved these changes
Feb 10, 2019
chemamartinez
pushed a commit
that referenced
this pull request
Feb 12, 2019
…me>/address". (#2550) * Linux syscollector: retrieve MAC addresses from "/sys/class/net/<ifname>/address". * Fixed wrong fread() call + variable naming convention. * Let Syscollector get a shorter MAC address. Some tunneling interfaces have a shorter MAC, like "00:00:00:00"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2532 by reading the real MAC address for each interface using data at "/sys/class/net//address" instead of only getting it from interfaces with AF_PACKET sockets, avoiding problems with bonded interfaces sharing the same MAC address at software level.