Prevent Execd from becoming defunct when Active Response disabled

[vikman90]

Execd performs two main tasks:

• Active Response.
• Command dispatching.

This means that Execd must run either Active Response is enabled or disabled.

But, if We disable Active Response:

<active-response>
  <disabled>yes</disabled>
</active-response>

Then, Execd appears as defunct:

# ps -ef | grep defu
root     29916     1  0 13:12 ?        00:00:00 [ossec-execd] <defunct>

Rationale

Execd starts the command dispatching thread after parsing its configuration. Then, if Active Response is disabled, it closes its main thread (pthread_exit()). This works but lets Execd appear as defunct.

Proposed fix

Let Execd join the command dispatcher thread instead of closing the main thread.

[chemamartinez]

Hi @vikman90,

The PR works as expected. However, I have noticed when testing it that, when AR is disabled in agents, two errors are shown when starting by default:

2019/02/26 10:40:57 ossec-agentd: ERROR: (1210): Queue '/queue/alerts/execq' not accessible: 'No such file or directory'.
2019/02/26 10:40:57 ossec-agentd: ERROR: Unable to connect to the active response queue (disabled).

Since AR can be disabled, I consider the second one is not an error, so let me change it to an informational message.

Regards.