Replaced strtoul() using NULL arguments with atol() in wodles' config files. #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has been added a commit (f8b8521) for not accepting negative values at intervals and timeouts when reading the configuration. It also allows starting some modules when setting an interval lower than 60 seconds, by overwriting the interval value to the lowest one valid instead of stopping the execution. |
chemamartinez
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strtoul() was causing some issues (specially in the docker wodle), as it was reading characters as numeric values, causing unexpected behaviour. The solution was replacing it with atol(), which only reads numeric values.
This PR fixes the issue #2768