Avoid giving an error when one of the file permissions cannot be extracted #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file has permissions for an account whose name is unknown, this error appeared:
Since 463857e, if the permission of a file cannot be extracted, it ignores it and shows the rest of the permissions.
{ "syscheck":{ "path":"c:\\windows\\sysnative\\drivers\\wd\\wdboot.sys", "size_after":"46680", "win_perm_after":[ { "name":"ALL APPLICATION PACKAGES", "allowed":[ "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_READ_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES" ] }, { "name":"Users", "allowed":[ "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_READ_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES" ] }, { "name":"TrustedInstaller", "allowed":[ "DELETE", "READ_CONTROL", "WRITE_DAC", "WRITE_OWNER", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_WRITE_DATA", "FILE_APPEND_DATA", "FILE_READ_EA", "FILE_WRITE_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES", "FILE_WRITE_ATTRIBUTES" ] }, { "name":"SYSTEM", "allowed":[ "DELETE", "READ_CONTROL", "WRITE_DAC", "WRITE_OWNER", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_WRITE_DATA", "FILE_APPEND_DATA", "FILE_READ_EA", "FILE_WRITE_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES", "FILE_WRITE_ATTRIBUTES" ] }, { "name":"Administrators", "allowed":[ "DELETE", "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_WRITE_DATA", "FILE_APPEND_DATA", "FILE_READ_EA", "FILE_WRITE_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES", "FILE_WRITE_ATTRIBUTES" ] } ], "uid_after":"S-1-5-18", "md5_after":"e7e16778c8440bb459c94b5ad8282491", "sha1_after":"263274388b2e3f9adbcdf42b8eaadbb8cb5689b6", "sha256_after":"728b2208884b4244e3481ddd82f9b353fc27dac77488dbc8224ab1630616676a", "attrs_after":[ "ARCHIVE" ], "uname_after":"SYSTEM", "mtime_after":"2018-12-12T09:36:00", "event":"added" } }Since 92e3c99, for this type of permissions the SID of the applied account will be shown.
{ "syscheck":{ "path":"c:\\windows\\sysnative\\drivers\\wd\\wdboot.sys", "size_after":"46680", "win_perm_after":[ { "name":"ALL APPLICATION PACKAGES", "allowed":[ "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_READ_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES" ] }, { "name":"S-1-15-3-1024-3153509613-960666767-3724611135-2725662640-12138253-543910227-1950414635-4190290187", "allowed":[ "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_READ_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES" ] }, { "name":"Users", "allowed":[ "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_READ_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES" ] }, { "name":"TrustedInstaller", "allowed":[ "DELETE", "READ_CONTROL", "WRITE_DAC", "WRITE_OWNER", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_WRITE_DATA", "FILE_APPEND_DATA", "FILE_READ_EA", "FILE_WRITE_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES", "FILE_WRITE_ATTRIBUTES" ] }, { "name":"SYSTEM", "allowed":[ "DELETE", "READ_CONTROL", "WRITE_DAC", "WRITE_OWNER", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_WRITE_DATA", "FILE_APPEND_DATA", "FILE_READ_EA", "FILE_WRITE_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES", "FILE_WRITE_ATTRIBUTES" ] }, { "name":"Administrators", "allowed":[ "DELETE", "READ_CONTROL", "SYNCHRONIZE", "FILE_READ_DATA", "FILE_WRITE_DATA", "FILE_APPEND_DATA", "FILE_READ_EA", "FILE_WRITE_EA", "FILE_EXECUTE", "FILE_READ_ATTRIBUTES", "FILE_WRITE_ATTRIBUTES" ] } ], "uid_after":"S-1-5-18", "md5_after":"e7e16778c8440bb459c94b5ad8282491", "sha1_after":"263274388b2e3f9adbcdf42b8eaadbb8cb5689b6", "sha256_after":"728b2208884b4244e3481ddd82f9b353fc27dac77488dbc8224ab1630616676a", "attrs_after":[ "ARCHIVE" ], "uname_after":"SYSTEM", "mtime_after":"2018-12-12T09:36:00", "event":"added" } }It affects Wazuh 3.8.X.