Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage timeout error in TCP connections #3426

Merged
merged 1 commit into from Jun 3, 2019
Merged

Manage timeout error in TCP connections #3426

merged 1 commit into from Jun 3, 2019

Conversation

albertomn86
Copy link
Contributor

@albertomn86 albertomn86 commented May 30, 2019 •
edited

Related issue
#3376

Description

This PR solves the issue #3376.
The timeout error is managed and now this error is logged only in debug.
Error codes EAGAIN, EWOULDBLOCK and ETIMEDOUT were added to ensure compatibility.

Logs/Alerts example

2019/05/30 11:44:17 ossec-remoted[12184] secure.c:196 at HandleSecure(): DEBUG: TCP peer [12] at 192.168.99.77: Connection timed out (110)

Tests

  • Compilation without warnings in every supported platform:
    • Linux
  • Source installation
  • Source upgrade
  • Retrocompatibility with older Wazuh versions

@albertomn86 albertomn86 requested a review from vikman90 May 30, 2019 09:47
vikman90
vikman90 approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@vikman90 vikman90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikman90 vikman90 merged commit e526ffd into 3.9 Jun 3, 2019
@vikman90 vikman90 deleted the 3376-remoted-timeout-error branch June 3, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaow snaow snaow approved these changes

@vikman90 vikman90 vikman90 approved these changes

Assignees
No one assigned
Labels
module/remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertomn86 @snaow @vikman90