Avoid processing null elements of an array in Vulnerability Detector #3458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents the bug described in the issue, and also protects it from happening in the other string array that we can find in a vulnerability node:
affected_packages
.However, a null element in
affected_packages
does not produce a segmentation fault as it does if this element is found inadvisories
.The fix consists of adding a null check on the elements of the array.
Configuration options
Considering that this error is not replicable with the currently hosted feed, the configuration must involve an offline update. We can use
url
orpath
for this.To replicate it, we have to download a feed and modify one of its vulnerabilities by adding
null
value to an array of strings like:Tests