Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in Logcollector when formatting a message #4968

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Fix memory leak in Logcollector when formatting a message #4968

merged 1 commit into from
Apr 29, 2020

Conversation

FernandoCP
Copy link
Contributor

@FernandoCP FernandoCP commented Apr 28, 2020 •
edited by vikman90

Description

Memory leak detected in a stress test in Ubuntu agent. It is caused by a change in this PR #4942. To fix this, a memory free has been added in the modified code.

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation

  • Memory tests for Linux

    • Scan-build report
    • Coverity
    • Valgrind (memcheck and descriptor leaks check)

  • Memory tests for Windows

    • Scan-build report
    • Coverity

  • Memory tests for macOS

    • Scan-build report

@FernandoCP FernandoCP changed the title Fix memory leak on <out_format> Fix memory leak in Logcollector when formatting a message Apr 28, 2020
@FernandoCP FernandoCP changed the base branch from master to 3.12 April 28, 2020 10:11
vikman90
vikman90 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@vikman90 vikman90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikman90 vikman90 mentioned this pull request Apr 28, 2020
Merged
10 tasks
@vikman90 vikman90 self-assigned this Apr 28, 2020
@vikman90 vikman90 added type/bug Something isn't working type/bug/regression Breaks functionality known to work in previous releases module/logcollector labels Apr 28, 2020
@vikman90
Copy link
Member

This bug was caused by PR #4942.

@vikman90 vikman90 added this to the Sprint 111 - Core milestone Apr 28, 2020
@vikman90 vikman90 merged commit 2ad3f8c into 3.12 Apr 29, 2020
@vikman90 vikman90 deleted the Fix-memory-leak-out-format branch April 29, 2020 08:54
@vikman90 vikman90 mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikman90 vikman90 vikman90 approved these changes

Assignees

@vikman90 vikman90

Labels
module/logcollector reporter/cicd type/bug/regression Breaks functionality known to work in previous releases type/bug Something isn't working
Projects
None yet
Milestone
Sprint 111 - Core
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FernandoCP @vikman90 @alberpilot