Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minor fixes for 4.1.0 in Wazuh modules daemon #7028

Merged
merged 8 commits into from
Dec 30, 2020
Merged

Add minor fixes for 4.1.0 in Wazuh modules daemon #7028

merged 8 commits into from
Dec 30, 2020

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Dec 24, 2020 •
edited

Description

This pull request includes several minor fixes:

  • Switch a warning to info message when the command module is disabled by configuration. To be consistent with the rest of the components. 8c8b1ec
  • Fix a typo in the SCA tag when an interval overtaken happens. be4428b
  • Freeing a buffer in SCA even it will never be freed since it is after a forever loop (just a visual change). e8d9567
  • Add PID to the starting log for Wazuh modules daemon. e452984
2020/12/30 15:59:10 wazuh-modulesd: INFO: Started (pid: 81197).
  • Remove duplicated group assignment when starting the Wazuh modules daemon. 33435c9
  • The SCA scan duration was not measured correctly, it always counted 0 seconds on the first scan. d93a7bf
2020/12/30 15:59:18 sca: INFO: Security Configuration Assessment scan finished. Duration: 8 seconds.

Tests

  • Compilation in Linux
  • Source installation
  • Running an SCA scan to check everything work fine
  • Scan-build report

@chemamartinez chemamartinez self-assigned this Dec 24, 2020
@chemamartinez chemamartinez marked this pull request as ready for review December 28, 2020 20:18
@chemamartinez chemamartinez mentioned this pull request Dec 28, 2020
Closed
1 task
0xN3utr0n
0xN3utr0n approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@0xN3utr0n 0xN3utr0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

spothound
spothound approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@spothound spothound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez chemamartinez changed the title Silence valgrind report about a dynamic allocated buffer when execvp() fails Add minor fixes for 4.1.0 in Wazuh modules daemon Dec 30, 2020
@chemamartinez chemamartinez merged commit 4b863de into 4.1 Dec 30, 2020
@chemamartinez chemamartinez deleted the 6997-sca-memleak branch December 30, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xN3utr0n 0xN3utr0n 0xN3utr0n approved these changes

@BraulioV BraulioV Awaiting requested review from BraulioV

@spothound spothound Awaiting requested review from spothound

Assignees

@chemamartinez chemamartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chemamartinez @spothound @0xN3utr0n