Change format for permissions on Windows from string to cJSON #9162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotacarma90
force-pushed
the
8585-win-perm-json
branch
2 times, most recently
from
4744cc0
to
1e5e17d
Compare
jotacarma90
force-pushed
the
8585-win-perm-json
branch
3 times, most recently
from
612c033
to
d103066
Compare
jotacarma90
changed the base branch from
master
to
8575-fim-win-perms-improvement
jotacarma90
force-pushed
the
8585-win-perm-json
branch
from
d103066
to
3adbd71
Compare
Refactors functions related to retrieving permissions in Windows in order to simplify usage and remove duplicated code.
Added some more UTs for changes associated with Windows permissions being in JSON format
Fix NULL derreferences in decode_ace_json and perm_json_to_old_format. Fix a memory leak in fim_registry_get_key_data. Silenced a false positive NULL derreference on lf->fields reported by scan-build.
Molter73
force-pushed
the
8585-win-perm-json
branch
from
25c7e18
to
0b08ea3
Compare
Molter73
added
module/fim
Added the required code for wazuh_db to properly save a file/registry permissions when it is formatted as JSON. Added unit tests for the new code.
Molter73
force-pushed
the
8585-win-perm-json
branch
from
0b08ea3
to
38c2218
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to change the way Windows file permissions will be processed, changing them from string format to a cJSON format.
Logs/Alerts example
Tests