Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An incompatibility was introduced with gpsd api 11 #330

Closed
Thomas-McCarthy opened this issue Apr 12, 2021 · 3 comments
Closed

An incompatibility was introduced with gpsd api 11 #330

Thomas-McCarthy opened this issue Apr 12, 2021 · 3 comments

Comments

@Thomas-McCarthy
Copy link

Thomas-McCarthy commented Apr 12, 2021

#if GPSD_API_MAJOR_VERSION < 5 || GPSD_API_MAJOR_VERSION > 11

Seems to be a regression from issue #222 and #295

An incompatibility was introduced again when using gpsd api 11 from gpsd: 3.22.1~dev (revision release-3.22-332-g743585cc3)
Increasing the
Changing GPSD_API_MAJOR_VERSION > 11 to 12 solves this.

#if GPSD_API_MAJOR_VERSION < 5 || GPSD_API_MAJOR_VERSION > 12

This issue exists in the dev branch

Maybe there is a cleaner way of implementing this fix.

Thomas-McCarthy added a commit to Thomas-McCarthy/direwolf that referenced this issue Apr 21, 2021
Fix for Issue wb2osz#330 

An incompatibility was introduced again when using gpsd api 11 from gpsd: 3.22.1~dev (revision release-3.22-332-g743585cc3)
Increasing the
Changing GPSD_API_MAJOR_VERSION > 11 to 12 solves this.
@aryanprophet
Copy link

Changing "GPSD_API_MAJOR_VERSION > 11" to "GPSD_API_MAJOR_VERSION > 12", solved the issue for me. It compiled with a few warnings, but it works. Thank you!!!

@wb2osz
Copy link
Owner

wb2osz commented Dec 21, 2021

Could you be more specific about what you mean "it works?"
Do you mean that it compiles properly or did you actually run it and observe that GPS location was being put in a tracker beacon?

@wb2osz
Copy link
Owner

wb2osz commented Apr 10, 2023

Compatibility has been tested up through gpsd 3.25 in the dev branch.
This will be merged to master when direwolf 1.7 is released.
Closed.

@wb2osz wb2osz closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants