Skip to content

Commit

Permalink
Merge pull request #15 from tandasat/master
Browse files Browse the repository at this point in the history
fix a comment error, and typo in README
  • Loading branch information
wbenny committed Oct 8, 2018
2 parents 2bf148f + 204f8f8 commit 85e5387
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions README.md
Expand Up @@ -98,7 +98,7 @@ read and navigate through 5000 pages with browser's built-in PDF reader.
- destroy each VCPU via IPI - for each VCPU `vmexit_handler::invoke_termination()` is called within `vcpu_t::destroy()`
method, which should be responsible for switching into VMX mode and then call `vcpu_t::terminate()`
- this is by default handled via `VMCALL` instruction
- `vcpu_t::terminate()` leaves VMX mode with `VMXOFF` instruction (which is available only in VMX mode),
- `vcpu_t::terminate()` leaves VMX mode with `VMXOFF` instruction (which is available only in VMX mode),

### Compilation

Expand Down Expand Up @@ -198,7 +198,7 @@ Run **hvppctrl**:
- because the function is still hooked, the hook function will be called and `HookCallCount` will be incremented
again
- prints value of `HookCallCount` and it's expected value - it should be 3
- unhooks `ntdll!ZwClose` fuction
- unhooks `ntdll!ZwClose` function
- disassembles first 16 bytes of this function and prints them
- printed instructions should now indicate that the function is **NOT** hooked - it should show the same content
as when this function wasn't hooked
Expand Down Expand Up @@ -227,7 +227,7 @@ When you decide you want to turn off the **hvpp**, just execute:

### Remarks

- **hvpp** is designed to virtualize already running OS - i.e. it's not cappable of running multiple guests like VMWare
- **hvpp** is designed to virtualize already running OS - i.e. it's not capable of running multiple guests like VMWare
or VirtualBox. It also lacks support for any nested VMX operations.
- **hvpp** is designed to run only on 64bit Intel processors, which support VT-x and EPT. This makes the code more
simple and less bloated.
Expand Down
2 changes: 1 addition & 1 deletion src/hvpp/hvpp/vcpu.cpp
Expand Up @@ -504,7 +504,7 @@ void vcpu_t::setup_guest() noexcept
// Note that we would still get VM-exit for each MSR access, if the MSR ID
// is out of following ranges:
// 0x00000000 - 0x00001fff and
// 0x80000000 - 0x80001fff
// 0xc0000000 - 0xc0001fff
//
msr_bitmap(vmx::msr_bitmap_t{});

Expand Down

0 comments on commit 85e5387

Please sign in to comment.