Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Zap button in onboarding #158

Closed
JimmyMow opened this issue Jan 31, 2019 · 4 comments · Fixed by #190
Closed

Add support for Zap button in onboarding #158

JimmyMow opened this issue Jan 31, 2019 · 4 comments · Fixed by #190

Comments

@JimmyMow
Copy link

JimmyMow commented Jan 31, 2019

Zap users frequently request my help for getting set up with Joule. I've noticed recently there is a Lightning App on-boarding button that looks to scan for the Lightning App's default port.

screen shot 2019-01-31 at 4 52 31 pm

I think there should be a Zap Desktop on-boarding button as well. Our default port is 8180 (source: https://github.com/LN-Zap/zap-desktop/blob/master/app/lib/lnd/neutrino.js#L29)

@wbobeirne
Copy link
Member

Hey, just looking into this now. Is there also a usual spot for macaroons to be?

@wbobeirne
Copy link
Member

Ah, found them in ~/Library/Application Support/Zap/lnd/bitcoin/[network]/[name-of-wallet]. This might be tricky for users who have more than one wallet though, as there's no distinguishing naming between them, just a random number. It'd be awesome if Zap had an option to open the folder that contains all the goods.

@mrfelton
Copy link

mrfelton commented Feb 4, 2019

Is there any way for Zap to communicate with Joule? Does Joule provide an accessible API of it's own?

@wbobeirne
Copy link
Member

No, chrome extensions are completely sandboxed. It's possible to implement native app communication through the Native messaging API but that would require some Joule-specific implementations on Zap's side that I don't imagine us collaborating on in the short term. I'm totally open to any suggestions from the Zap team though, if there's a desire to do so!

wbobeirne pushed a commit that referenced this issue May 2, 2021
…n/moment-2.29.1

Update moment: 2.27.0 → 2.29.1 (minor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants