Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to hide warnings and errors from direnv #61

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Allow user to hide warnings and errors from direnv #61

merged 2 commits into from
Mar 19, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 19, 2020

Resolves #60

@rvl rvl mentioned this pull request Mar 19, 2020
Closed
wbolster
wbolster reviewed Mar 19, 2020
View reviewed changes
Copy link
Owner

@wbolster wbolster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, also for extending the readme!

left a small comment, please have a look

README.rst Outdated

(use-package direnv
:custom
(warning-suppress-types '((direnv))))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will overwrite it completely, perhaps :config with (add-to-list ...) is a better suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK fixed.

wbolster
wbolster approved these changes Mar 19, 2020
View reviewed changes
Copy link
Owner

@wbolster wbolster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wbolster wbolster merged commit 1daf479 into wbolster:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbolster wbolster wbolster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*Warnings* buffer pops up when .envrc is blocked
2 participants
@rvl @wbolster