Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add perfectionist package #4746

Merged
merged 5 commits into from Sep 1, 2015
Merged

add perfectionist package #4746

merged 5 commits into from Sep 1, 2015

Conversation

yisibl
Copy link
Contributor

@yisibl yisibl commented Aug 30, 2015

A Powerful Sublime Text plugin to beautify CSS!

https://github.com/yisibl/sublime-perfectionist

@princemaple
Copy link
Contributor

@yisibl
Copy link
Contributor Author

yisibl commented Aug 30, 2015

Sorry, my mistake.

Please merge it,thanks!

@princemaple
Copy link
Contributor

I'm not an admin, just happened to see the PR and got interested by the package name.

@FichteFoll
Copy link
Collaborator

In the menu you use "CSS Perfectionist", which I personally would favor as a package name over just "Perfectionist" (keywords, etc.), but that's optional.

However, you'll need to change "branch": "master" to "tags": true. As mentioned in the docs, we no longer accepts branch-based releases for new packages.

@yisibl
Copy link
Contributor Author

yisibl commented Sep 1, 2015

Fix.

If only Perfectionist, the user is not easy to enter and search.Thank you for your advice.

@FichteFoll
Copy link
Collaborator

If only Perfectionist, the user is not easy to enter and search.

That is a non-argument since typing "Perfectionist" will also match "CSS Perfectionist" just fine, both in Sublime Text and on packagecontrol.io.

@yisibl
Copy link
Contributor Author

yisibl commented Sep 1, 2015

So, now can you merge it?

@princemaple
Copy link
Contributor

I'd +1 CSS Perfectionist. Just saying.

@FichteFoll
Copy link
Collaborator

So, now can you merge it?

I can. But does it mean I will?

Maybe you should work on your tone, for the future.

FichteFoll added a commit that referenced this pull request Sep 1, 2015
@FichteFoll FichteFoll merged commit 5c41c91 into wbond:master Sep 1, 2015
@princemaple
Copy link
Contributor

@FichteFoll this guy obviously doesn't speak English as first language, hope you are not too offended. (saying that because I can tell from his email that he's from the same country as I am)

@yisibl
Copy link
Contributor Author

yisibl commented Sep 1, 2015

@FichteFoll I'm so sorry, my English is too bad.

@FichteFoll
Copy link
Collaborator

this guy obviously doesn't speak English as first language

Yes, I realize that. I'm not really offended by the comments, but reviewing packages is a pretty thankless task, so I can get a bit bitter occasionally. Sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants