Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Tandem" Package #6986

Closed
wants to merge 2 commits into from
Closed

Add "Tandem" Package #6986

wants to merge 2 commits into from

Conversation

rageandqq
Copy link

Tandem is a solution that allows for decentralized, cross-editor collaborative editing!
This is the Sublime plugin for Tandem.

Thanks in advance for reviewing!

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Tandem
Results help

Packages added:
  - Tandem

Processing package "Tandem"
  - WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary

@odeckmyn
Copy link

please accept this one !

Copy link
Owner

@wbond wbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this invoke shell scripts or load shared libs, so as to need the .no-sublime-package file?

{
"name": "Tandem",
"details": "https://github.com/typeintandem/sublime",
"labels": ["Tandem", "collaborative", "cross-editor", "real-time"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tandem label isn't necessary since that is the name of the package.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Apr 13, 2018

You import from tandem but your package will be installed as Tandem. Python is case-sensitive (and many file systems are as well).

In your readme, you mention view.run_command("tandem_connect", "abcd-1234"). This will not work, since the second argument to run_command must be a mapping (i.e. a dict).

Does this invoke shell scripts or load shared libs, so as to need the .no-sublime-package file?

It runs a python daemon.

@Thom1729 Thom1729 added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label May 6, 2018
@FichteFoll
Copy link
Collaborator

@rageandqq ping

@FichteFoll FichteFoll added timeout A pull request needed changes but was not updated in time (2 weeks after becoming stale) and removed stale The pull request needs to be updated but has not been within the recent past (2 weeks) labels Sep 11, 2018
@FichteFoll FichteFoll closed this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timeout A pull request needed changes but was not updated in time (2 weeks after becoming stale)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants