Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SumoSwissKnife package #7721

Merged
merged 4 commits into from Jan 8, 2020
Merged

Conversation

scrummastermind
Copy link
Contributor

@scrummastermind scrummastermind commented Oct 21, 2019

This is to add SumoSwissKnife a collection of tools to work with Sumo Logic Log Management APIs

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: SumoSwissKnife
Results help

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - ERROR: `messages` folder exists, but `messages.json` does not
  - ERROR: '.sublime-package' files have no business being inside a package
    - File: SumoSwissKnifeAPI/.sublime-package
  - ERROR: Invalid JSON (with comments)
    - File: SumoLogic.sublime-completions
    - Exception: Expecting value: line 70 column 1 (char 69)
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: syntax_test_SumoLogicOutput.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: syntax_test_SumoLogic.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Regular Expressions (Sumo).sublime-syntax

@scrummastermind
Copy link
Contributor Author

fixed errors

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: SumoSwissKnife
Results help

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - ERROR: '.sublime-package' files have no business being inside a package
    - File: SumoSwissKnifeAPI/.sublime-package
  - ERROR: `messages` folder exists, but `messages.json` does not
  - ERROR: Invalid JSON (with comments)
    - File: SumoLogic.sublime-completions
    - Exception: Expecting value: line 70 column 1 (char 69)
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: syntax_test_SumoLogicOutput.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: syntax_test_SumoLogic.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Regular Expressions (Sumo).sublime-syntax

@scrummastermind
Copy link
Contributor Author

Fixed errors

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: SumoSwissKnife
Results help

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - ERROR: `messages` folder exists, but `messages.json` does not
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogic.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogicOutput.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Regular Expressions (Sumo).sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: SumoSwissKnife
Results help

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - ERROR: File 'messages/0.0.1.md', as specified by key 'v0.0.1', does not exist
    - File: messages.json
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogic.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogicOutput.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Regular Expressions (Sumo).sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: SumoSwissKnife
Results help

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - ERROR: File 'messages/0.0.1.md', as specified by key 'v0.0.1', does not exist
    - File: messages.json
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogic.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogicOutput.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Regular Expressions (Sumo).sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: SumoSwissKnife
Results help

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogic.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SumoLogicOutput.sublime-syntax
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: Regular Expressions (Sumo).sublime-syntax

Restricting to 3092
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: SumoSwissKnife

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: SumoSwissKnife

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - All checks passed

@FichteFoll
Copy link
Collaborator

Are you sure this needs to be limited to macOS? This mostly seems to be general support for a language with a syntax definition and completions, which are perfectly cross-platform. The Python code is a bit too much for me to review in detail, but even if that was platform-specific you could just disable it when it's not supported.

Keys in messages.json must be actual versions, i.e. not have the v prefix.

@FichteFoll
Copy link
Collaborator

@scrummastermind ping

@FichteFoll FichteFoll added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Jan 3, 2020
@scrummastermind
Copy link
Contributor Author

OS Restriction removed

@scrummastermind
Copy link
Contributor Author

OS Restriction removed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: SumoSwissKnife

Packages added:
  - SumoSwissKnife

Processing package "SumoSwissKnife"
  - All checks passed

@scrummastermind
Copy link
Contributor Author

scrummastermind commented Jan 6, 2020

@FichteFoll ping

@FichteFoll
Copy link
Collaborator

FichteFoll commented Jan 6, 2020

Please remove the v from the key here.

@scrummastermind
Copy link
Contributor Author

scrummastermind commented Jan 7, 2020

Please remove the v from the key here.

@FichteFoll , All Done!

@FichteFoll FichteFoll merged commit 06be6f7 into wbond:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale The pull request needs to be updated but has not been within the recent past (2 weeks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants