Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+shift+p (for search bar) opens a private session on firefox #28

Open
FichteFoll opened this issue Aug 18, 2014 · 3 comments
Open

Comments

@FichteFoll
Copy link
Contributor

I practically can't use the binding, even though I'm used to it from ST.

I think it should be possible to just prevent the event from propagating when it was processed to focus the search panel, since you'll rarely need that binding exactly when you are browsing the package listing. There are ofc bindings where this would not be an option, e.g. "ctrl+tab".

@tylermumford
Copy link

It's definitely inconvenient for Firefox users, and preventDefault would be great, if it works. One other possible improvement would be to give the search field tabindex="0" so it becomes the first element focused with just Tab.

@math2001
Copy link

math2001 commented Sep 28, 2016

+1, on chrome, it opens a window to print the page...

math2001 added a commit to math2001/packagecontrol.io that referenced this issue Sep 28, 2016
@FichteFoll FichteFoll changed the title ctrl+shift+p (for search par) opens a private session on firefox ctrl+shift+p (for search bar) opens a private session on firefox Nov 26, 2016
@ZaLiTHkA
Copy link

ZaLiTHkA commented Apr 29, 2017

I see this ticket is still open, so just out of morbid curiosity, what about using / as the search bar focus shortcut? Seems far easier to me than preventing the default "print" dialog.. O.o It's also a much simpler shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants