#237: Removes Jasmine + Karma. Introduces Jest + JSDOM + Testing Libr… #242
Conversation
…ting Library. Introduces simple changes into tests that are required to make tests work with new matchers.
|
@wbotelhos please check this out :) |
| beforeEach(function () { | ||
| this.target = Helper.create('#target'); | ||
| beforeEach(() => { | ||
| testContext.target = Helper.create('#target'); |
There was a problem hiding this comment.
💅 To avoid creating an extra variable and reset, we could just select this element on the expectation.
|
|
||
| done(); | ||
| }, 100); | ||
|
|
||
| jest.advanceTimersByTime(100) |
There was a problem hiding this comment.
Do we need it? The setTimeout was just because sometimes the target was not filled yet.
| @@ -291,7 +299,7 @@ describe('#precision', function () { | |||
| Helper.trigger(cancel, 'mouseover'); | |||
|
|
|||
| // then | |||
| expect(this.target).toHaveHtml(raty.opt.cancelHint); | |||
| expect(testContext.target[0]).toContainHTML(raty.opt.cancelHint); | |||
There was a problem hiding this comment.
Could we use the simplest selector possible like innerHTML? So we depend less on the framework.
| // given | ||
| var raty = new Raty(document.querySelector('#element'), { cancelButton: true, space: true }); | ||
|
|
||
| // when | ||
| raty.init(); | ||
|
|
||
| // then | ||
| expect(raty.element.innerText.length).toEqual(5); | ||
| expect(raty.element.textContent.length).toEqual(5); |
There was a problem hiding this comment.
Since it's a normal element, should we use textContent?
| @@ -713,7 +713,7 @@ class Raty { | |||
| _setTitle(score, evt) { | |||
| if (score) { | |||
| const integer = parseInt(Math.ceil(score), 10); | |||
| const star = this.stars[integer - 1]; | |||
| const star = this.stars.item(integer - 1); | |||
There was a problem hiding this comment.
Is it to avoid out of range value? I think we have an issue with mouseover when it's close to the cancel button where the value comes as negative, but I think it was already addressed.. don't know.
There was a problem hiding this comment.
Coz this.stars is not an array, but iterable.
| @@ -1,18 +1,26 @@ | |||
| function context(description, spec) { | |||
| const $ = require('jquery'); | |||
There was a problem hiding this comment.
Could we try to drop the jQuery? Or it would be in another PR?
#237: Removes Jasmine + Karma. Introduces Jest + JSDOM + Testing Library. Introduces simple changes into tests that are required to make tests work with new matchers.