Fix error when opt.half == true #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wbotelhos can you merge this one, please? The fix looks correct to me and it affects quite a few use cases, also when the rating is inside a |
qzminski
added a commit
to TSO-AG/OpenFrontend.Framework
that referenced
this pull request
Aug 23, 2023
|
Hi, @qzminski . Would be nice to have a test simulating the error, if you could try to do it later, I'll appreciate it. |
|
There you go: https://codepen.io/qzminski/pen/poqgLGQ |
qzminski
added a commit
to TSO-AG/OpenFrontend.Framework
that referenced
this pull request
Aug 31, 2023
* Add ratings component * CS * Configure the Rating component with JSON instead of `data` attributes * CS * Update the docs * Patch the raty-js plugin wbotelhos/raty#249 * Update the dist files * Automatically apply the package patches * Enable autoprefixer & stylelint * Allow to define custom icon * Update raty-js * CS --------- Co-authored-by: Kamil Kuzminski <kamil.kuzminski@codefog.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a space to the left of an element in Raty, incorrect coordinates are returned, resulting in an error.
https://codepen.io/fono0c/pen/MWBBjEP
This patch corrects the process of getting the coordinates of the element.
See below:
HTMLElement.offsetLeft: https://developer.mozilla.org/ja/docs/Web/API/HTMLElement/offsetLeft
Element.getBoundingClientRect: https://developer.mozilla.org/ja/docs/Web/API/Element/getBoundingClientRect
MouseEvent.pageX:
https://developer.mozilla.org/ja/docs/Web/API/MouseEvent/pageX