Merge pull request #6 from wbrakowski/wbrakowski/issue5

Wbrakowski/issue5
wbrakowski · Aug 13, 2022 · 8a354d7 · 8a354d7
2 parents 2a21111 + ac2dec4
commit 8a354d7
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/.vscode/rad.json b/.vscode/rad.json
@@ -1 +1 @@
-{"Added":[],"Modified":[],"Removed":[]}
+{"Added":[],"Modified":[{"Id":50000,"Kind":11,"Name":"Record Deletion Mgt.","PackagePath":"/src/src/codeunit/RecordDeletionMgt.Codeunit.al"}],"Removed":[{"Id":0,"Kind":11,"Name":"_symbolcache","PackagePath":"/src/.vscode/temp-al-proxy.al"}]}
diff --git a/app.json b/app.json
@@ -13,14 +13,15 @@
   "dependencies": [
   ],
   "screenshots": [],
-  "platform": "19.0.0.0",
-  "application": "19.0.0.0",
+  "platform": "20.0.0.0",
+  "application": "20.0.0.0",
   "idRanges": [
     {
       "from": 50000,
       "to": 50099
     }
   ],
   "contextSensitiveHelpUrl": "https://Record-Deletion-Tool.com/help/",
-  "runtime": "8.0"
+  "runtime": "9.0",
+  "target": "Cloud"
 }
diff --git a/extensionsPermissionSet.xml b/extensionsPermissionSet.xml
@@ -2,7 +2,7 @@
 <PermissionSets>
   <PermissionSet RoleID="RECORD-DELETION-TOOL" RoleName="Record-Deletion-Tool">
     <Permission>
-      <ObjectID>50100</ObjectID>
+      <ObjectID>50000</ObjectID>
       <ObjectType>0</ObjectType>
       <ReadPermission>1</ReadPermission>
       <InsertPermission>1</InsertPermission>
@@ -12,7 +12,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>50100</ObjectID>
+      <ObjectID>50000</ObjectID>
       <ObjectType>1</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -22,7 +22,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>50101</ObjectID>
+      <ObjectID>50001</ObjectID>
       <ObjectType>0</ObjectType>
       <ReadPermission>1</ReadPermission>
       <InsertPermission>1</InsertPermission>
@@ -32,7 +32,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>50101</ObjectID>
+      <ObjectID>50001</ObjectID>
       <ObjectType>1</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -42,7 +42,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>50100</ObjectID>
+      <ObjectID>50000</ObjectID>
       <ObjectType>5</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -52,7 +52,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>50101</ObjectID>
+      <ObjectID>50000</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>
@@ -62,7 +62,7 @@
       <SecurityFilter />
     </Permission>
     <Permission>
-      <ObjectID>50100</ObjectID>
+      <ObjectID>50001</ObjectID>
       <ObjectType>8</ObjectType>
       <ReadPermission>0</ReadPermission>
       <InsertPermission>0</InsertPermission>

diff --git a/src/codeunit/RecordDeletionMgt.Codeunit.al b/src/codeunit/RecordDeletionMgt.Codeunit.al
@@ -551,10 +551,13 @@ codeunit 50000 "Record Deletion Mgt."
     begin
         case true of
             //5005270 - 5005363
-            (TableID >= Database::"Delivery Reminder Header") and (TableID <= Database::"Phys. Invt. Diff. List Buffer"):
+            // 5005363 = "Phys. Invt. Diff. List Buffer"
+            // (TableID >= Database::"Delivery Reminder Header") and (TableID <= Database::"Phys. Invt. Diff. List Buffer"):
+            (TableID >= 5005270) and (TableID <= 5005363):
                 exit(true);
             //99000750 - 99008535
-            (TableID >= Database::"Work Shift") and (TableID <= 99008535):
+            // 99000750 = Workshift
+            (TableID >= 99000750) and (TableID <= 99008535):
                 exit(true);
             // Microsoft Localizations
             (TableID >= 100000) and (TableID <= 999999):