Platform API returns batches where parent wiki has been deleted #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Apr 2, 2024
| @@ -34,9 +34,17 @@ public function tearDown (): void | |||
| public function testGetEmpty (): void | |||
| { | |||
| $this->json('GET', $this->route.'/getBatches') | |||
| ->assertJson([]) | |||
| ->assertJsonCount(0) | |||
There was a problem hiding this comment.
This never worked until now and would have let any response wrapped in an array pass.
There was a problem hiding this comment.
Luckily, it's also the only place in the tests where we seem to do this.
There was a problem hiding this comment.
comment: that's a good catch; on googling it looks like we could also have $response->assertExactJson(..) which doesn't do this more permissive check
There was a problem hiding this comment.
That's good to know, will change.
tarrow
reviewed
Apr 2, 2024
| @@ -14,6 +14,7 @@ public function handle(): void | |||
| ['pending_since', '=', null], | |||
| ['updated_at', '<', Carbon::now()->subMonths(1)], | |||
| ]) | |||
| ->union(QsBatch::doesntHave('wiki')) | |||
There was a problem hiding this comment.
good idea to add this so that they don't clog up and never get cleared
tarrow
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T361571