Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cookie_lifetime param is misplaced #12

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: cookie_lifetime param is misplaced #12

merged 1 commit into from
Feb 7, 2024

Conversation

m90
Copy link
Contributor

@m90 m90 commented Feb 7, 2024

#11 passed the $cookie_lifetime parameter in the wrong place. It is a parameter of MW_OAuth not getOauthParams

tarrow
tarrow approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that I obviously missed entirely!

@m90 m90 merged commit a16a9f3 into main Feb 7, 2024
1 check passed
@m90 m90 deleted the fr/fix-param branch February 7, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrow tarrow tarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@m90 @tarrow