fix: cleaning prefixes removes all instances instead of retaining wanted ones #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
force-pushed
the
fr/keep-prefix
branch
2 times, most recently
from
4b030b3
to
8b5f492
Compare
|
I wrote a mini essay on the ticket rather than on here after spending a while looking at the code and also trying to interpret what it "should" be doing; I think this patch does actually solve the user's problem as described but causes a regression in what was probably sort of the feature set from before. |
tarrow
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T347023
I have to admit I have a very hard time understanding what the original function was trying to do, so I rebuilt it to do what I think it should be doing. This might well be wrong.