Fix git prompt leading to UI freeze #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nanotee Thank you! I've been meaning to get to this, but hadn't made the time. I think @bfredl was the primary user experiencing this issue. Also @gwerbin in #63. If either of you all (or anyone else who can reproduce the issue) could verify that this PR fixes the problem for you, I'll happily merge this. |
nanotee
force-pushed
the
fix-git-prompt-freeze
branch
from
cfadbe9
to
75a7ede
Compare
|
@wbthomason yes it fixes it :) |
|
Great, thank you! (and thanks @nanotee for the PR!) |
This was referenced Nov 23, 2020
Closed
This was referenced Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have managed to reproduce issue #40 (and #42 / #26, possibly?), this PR implements a fix using the
GIT_TERMINAL_PROMPTenvironment variable.I would really appreciate it if people who encounter the issue could test the PR to see if it fixes the problem for them as well