Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails if you lack module.exports.tslint.configuration (if you put your tslint config in a separate file) #57

Open
wcarmon opened this issue Dec 7, 2016 · 8 comments
Labels

Comments

@wcarmon
Copy link

wcarmon commented Dec 7, 2016

this fails with tslint 3.15.x and tslint 4.0.x

// on 4.0.x
Module build failed: TypeError: Cannot read property 'findConfiguration' of undefined
at resolveOptions (.../node_modules/tslint-loader/index.js:28:63)

// on 3.15.x
Module build failed: TypeError: Cannot read property 'findConfiguration' of undefined
at resolveOptions (.../node_modules/tslint-loader/index.js:26:63)

Workaround is to have an empty configuration object in webpack.config.js
(at module.exports.tslint.configuration)

@piq9117
Copy link

piq9117 commented Dec 15, 2016

it doesnt seem to work for me..
i have "tslint-loader": "^3.3.0", & "tslint": "^3.15.1",
I still get

TypeError: Cannot read property 'findConfiguration' of undefined

@vlio20
Copy link

vlio20 commented Jan 1, 2017

@piq9117, @wcarmon - were you able to solve this issue? I am using webpack2 rc3

@afnpires
Copy link

By updating to versions 4.3.1 of tslint and 3.3.0 of tslint-loader the error ceases to exist.

@sonicoder86
Copy link
Collaborator

sonicoder86 commented Feb 12, 2017

It needs Tslint 4.0+ and there is also a test case for no tslint configuration, does the bug still exist?

@sonicoder86
Copy link
Collaborator

Added explicit check for Tslint version in code and documentation.

@ollwenjones
Copy link

running into something similar, but only if I'm consuming typescript from within node_modules (in my case, peer scoped packages, npm linked together.)

@sonicoder86
Copy link
Collaborator

@wcarmon can you provide an example repository?

@wcarmon
Copy link
Author

wcarmon commented Apr 22, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants