Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-4.0.0-beta.2 compat: options deprecated #95

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

claudiordgz
Copy link
Contributor

Fixes #94

I wanted to try out webpack-4.0.0-beta.2 to see if my bundle would build any faster.

Turns out Compiler.options is now deprecated so I check for it before using it.

I was able to get some sweet ts-lint on my project after these 2 changes.

image

@sonicoder86
Copy link
Collaborator

Thanks for the fix!

@sonicoder86 sonicoder86 merged commit 34cac5e into wbuchwalter:master Feb 20, 2018
@thilak-rao
Copy link

Ran into the same while trying out Webpack 4 today. Thanks for the fix @claudiordgz

@BlackSonic now that Webpack 4 is stable, it would be nice if you could publishing a new version of tslint-loader to npm?

I got around my issue by referencing @claudiordgz's commit (0932300) in my package.json

"devDependencies": {
    "ts-loader": "4.0.0",
    "tslint": "5.9.1",
    "tslint-clean-code": "0.2.3",
    "tslint-loader": "https://github.com/wbuchwalter/tslint-loader.git#093230076f3b453c4f8b7aa2ee074932aa109e84",
    "typescript": "2.7.2",
    "webpack": "4.0.0",
    "webpack-cli": "2.0.9"
  }

@mbuckley
Copy link

@BlackSonic - I'm looking to pickup this fix in my webpack v4 setup. Would you mind creating a release tag that includes this fix?

v3.5.3...master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants