Skip to content

Commit

Permalink
Removed a few TODOs.
Browse files Browse the repository at this point in the history
These really aren't worth doing. The comments have been expanded to
better explain what's going on as well.
  • Loading branch information
wbyoung committed Jun 21, 2015
1 parent 44f6648 commit 75bee04
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 2 additions & 4 deletions lib/relations/belongs_to_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,9 @@ module.exports = Mixin.create(/** @lends BelongsTo# */ {
configure: function() {
/* jshint expr: true */

// TODO: this could be refactored to actually do configuration in this
// method rather than simply calling each property.

// configure each of the properties that are calculated on a delay by
// simply invoking the property once.
// simply invoking the property once. configure the inverse first as some
// other calculations may rely on it.
this.inverse;
this.primaryKey;
this.primaryKeyAttr;
Expand Down
6 changes: 2 additions & 4 deletions lib/relations/has_many_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,9 @@ module.exports = Mixin.create(/** @lends HasMany# */ {
configure: function() {
/* jshint expr: true */

// TODO: this could be refactored to actually do configuration in this
// method rather than simply calling each property.

// configure each of the properties that are calculated on a delay by
// simply invoking the property once.
// simply invoking the property once. configure the inverse first as some
// other calculations may rely on it.
this.inverse;
this.primaryKey;
this.primaryKeyAttr;
Expand Down

0 comments on commit 75bee04

Please sign in to comment.