Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DL requires silencing of 2 warnings on msvc to compile "cleanly" #149

Open
wc-duck opened this issue Oct 9, 2022 · 0 comments
Open

DL requires silencing of 2 warnings on msvc to compile "cleanly" #149

wc-duck opened this issue Oct 9, 2022 · 0 comments

Comments

@wc-duck
Copy link
Owner

wc-duck commented Oct 9, 2022

DL should compile cleanly out of the box, today to compile with /W4 on msvc you need to silence warning C4324 C4127", see https://github.com/wc-duck/datalibrary/blob/master/bam.lua#L181
These are imho quite silly warnings, but regardless of what I think they are there and need to be handled. Silence these in code or fix the code!
Tisten added a commit to Tisten/datalibrary that referenced this issue Dec 24, 2023
@Tisten
Fix for wc-duck#149
1dfecea 
if constexpr where needed and explicit padding generated
wc-duck pushed a commit that referenced this issue Feb 25, 2024
@Tisten
Fix for #149 (#180)
d4c4531 
* Fix for #149

if constexpr where needed and explicit padding generated

* gcc/clang compiler warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wc-duck