Added support for includes #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 1, 2022 12:15
wc-duck
reviewed
Dec 10, 2023
include/dl/dl_typelib.h
Outdated
| dl_ctx - dl-context to load typelib into. | ||
| file_to_include - the path to the file to include | ||
| */ | ||
| typedef dl_error_t ( *dl_include_handler )( void* handler_ctx, dl_ctx_t dl_ctx, const char* file_to_include ); |
There was a problem hiding this comment.
Pass a struct with ctx and include-path/id and user data instead, this to make api easier to extend.
There was a problem hiding this comment.
I know where you are coming from, but in this case I disagree for one important reason, this is a function which DL calls and the user of dl implements.
I want a compile error when the signature changes. Otherwise I might miss a change and thus not implement support for the functionality the new argument. If this had been a function which DL implemented and only the called would have to pass in a struct which can be default constructed then I would agree with you.
# Conflicts: # tests/dl_tests_typelib.cpp
# Conflicts: # src/dl_typelib_read_txt.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#165