Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very slow #21

Closed
hnry opened this issue Apr 22, 2013 · 3 comments
Closed

very slow #21

hnry opened this issue Apr 22, 2013 · 3 comments

Comments

@hnry
Copy link
Contributor

hnry commented Apr 22, 2013

original:

This module is slow.

In my testing, it seems more than 10 times slower compared to not using this module.
This is without variables such as network latencies etc.

I feel like this module can be faster, 10 times slower is too much.

edited:

This module is slow.

Using stubs, and not actually doing any real session loading, purely just testing the module it is more than 10 times slower compared to not using this module.

I feel like this module can be faster, 10 times slower is too much.

My results look something like this out of a run count of 10000000:

Without using this module

  • op/s: 10004360 | time: 0.99956419

With this module (but no real session loading, it's all stubbed) so this is purely testing the module's performance with no outside factors

  • op/s: 780283 | time: 12.815870532
@wcamarao
Copy link
Owner

Thanks for your feedback @LoveBear, however you're not being specific. Why is the module slow on your test? Where is the bottleneck? I'd really appreciate if you could provide helpful information in addition to your criticism. If you're not sure you can paste your two implementations (with and without the module) so we can help you figure out.

@hnry
Copy link
Contributor Author

hnry commented Apr 22, 2013

I'll do a pull request to speed the module up, I just wanted to get the discussion rolling so I posted this early.

@hnry
Copy link
Contributor Author

hnry commented Apr 22, 2013

closing, #22 let's continue there

@hnry hnry closed this as completed Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants