module slow, speed it up

[hnry]

This module is slow.

Using stubs, and not actually doing any real session loading, purely just testing the module it is more than 12 times slower compared to not using this module.

I feel like this module can be faster, 12 times slower is too much.

My results look something like this out of a run count of 10000000:

Without using this module (aka the baseline)

• op/s: 10004360 | time: 0.99956419

With this module (but no real session loading, it's all stubbed) so this is purely testing the module's performance with no outside factors

• op/s: 780283 | time: 12.815870532

[hnry]

After applying hnry@24922ea, the benchmark results look like this:

• op/s: 1284548 | time: 7.784841399

[hnry]

hnry@d9c18d9
( last commit )
Very minor improvement but it does seem to consistently give a few thousand op/s more

• op/s: 1313087 | time: 7.615640343

[wcamarao]

@LoveBear, I really appreciate your contribution, however I ran your benchmark with and without your changes and didn't notice a performance improvement, so I won't merge this change at least for now.

[hnry]

Are you sure you ran the benchmark correctly?

Without your module just the baseline:

node bench/bench

With your module:

node bench/bench session

If you did run it correctly, it would be very surprising to me considering

1. bind is slow
2. you don't even need bind or call, or fancy scoping

[wcamarao]

You're right, I had missed the argv on bench.js:39 so I haven't called with a 'session' arg. Now I see:

• op/s: 2111041 | time: 4.736998569 (original)
• op/s: 3659895 | time: 2.732318501 (modified)

Thanks for looking into this.