Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add 4th param "key" to README.md #37

Closed
ghost opened this issue Apr 30, 2014 · 2 comments
Closed

Please add 4th param "key" to README.md #37

ghost opened this issue Apr 30, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 30, 2014

I just noticed, after a bunch of hair pulling over why I was getting ([Error: could not look up session by key: connect.sid]) that there is a 4th param that doesn't seem to be mentioned in the README.md to set the key. It would be helpful to have this included since lots of us change the key name for security reasons.

@wcamarao
Copy link
Owner

Thanks for your feedback. It's already in the README. See section "Custom session store key"

@ghost
Copy link
Author

ghost commented May 1, 2014

Awesome :)

Hey, btw, I had some trouble setting up session.socket.io with express 4
today. I'm using redis store + session.socket.io + express 4 +
express-session(new separated middleware package which was removed from the
newer express).

It appeared that the cookie signatures didn't match between the heartbeat
object and express's req headers. I found the fix here(had to tweak it a
little and get rid of those regex + pop but it works now):

https://www.npmjs.org/package/session.socket.io-express4

Best,

Clinton

2014-04-30 15:26 GMT-05:00 Wagner Camarao notifications@github.com:

Closed #37 #37.


Reply to this email directly or view it on GitHubhttps://github.com//issues/37
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant