add: Fix incorrect Gid and Uid creation #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcampbell0x2a
force-pushed
the
fix-add-file-metadata
branch
from
91a8e34
to
0e8db1f
Compare
- Fix bug that a Gids and Uids were not entered as the value of the id, but as the index thus not actually saving the new Id. The fix is to let NodeHeader *always* contain the actual value of the id, and only write the index of the Gid and Uid when converting to InodeHeader
- Instead of incorrectly taking the Gid and Uid from the image, take from the added --file, also represent as u32 - When using --dir, force to give a uid/gid
wcampbell0x2a
force-pushed
the
fix-add-file-metadata
branch
3 times, most recently
from
50bb702
to
9b3b4bd
Compare
wcampbell0x2a
force-pushed
the
fix-add-file-metadata
branch
from
9b3b4bd
to
c8ef8de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
91a8e34 add: Read new file metadata from --file, force --dir
454cd8b backhand: Fix Uid and Gid adding to FilesystemWriter
1df1d83 add: Improve --help for dir
696e2b3 docs: Replace guid with gid
todo