Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filesystem.alloc_read_buffers() #530

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

wcampbell0x2a
Copy link
Owner

No description provided.

* Remove filesystem.alloc_read_buffers, as it was really only used as internal to
  the reader and thus this cleans up the API for readers.
@wcampbell0x2a wcampbell0x2a force-pushed the remove-filesystem-alloc-read-buffers branch from e74c118 to f238146 Compare April 14, 2024 05:33
Copy link

Benchmark for 048ef74

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.8±0.00ms 2.8±0.06ms 0.00%
only_read/tplink_ax1800 7.2±0.01ms 7.1±0.00ms -1.39%
unsquashfs/full 11.2±0.14ms 11.1±0.12ms -0.89%
unsquashfs/full-path-filter 7.9±0.08ms 7.8±0.05ms -1.27%
unsquashfs/list 8.2±0.05ms 8.1±0.10ms -1.22%
unsquashfs/list-path-filter 7.3±0.04ms 7.2±0.06ms -1.37%
write_read/netgear_ax6100v2 1273.5±2.23ms 1272.7±2.13ms -0.06%
write_read/tplink_ax1800 7.1±0.07s 7.0±0.01s -1.41%

Copy link

Benchmark for 47bb16d

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.8±0.01ms 2.7±0.00ms -3.57%
only_read/tplink_ax1800 7.2±0.02ms 7.1±0.01ms -1.39%
unsquashfs/full 11.3±0.16ms 11.2±0.20ms -0.88%
unsquashfs/full-path-filter 7.9±0.07ms 7.9±0.10ms 0.00%
unsquashfs/list 8.2±0.10ms 8.2±0.06ms 0.00%
unsquashfs/list-path-filter 7.3±0.04ms 7.3±0.03ms 0.00%
write_read/netgear_ax6100v2 1286.2±8.42ms 1283.2±2.95ms -0.23%
write_read/tplink_ax1800 7.1±0.06s 7.3±0.23s +2.82%

@wcampbell0x2a wcampbell0x2a merged commit c2360ec into master Apr 14, 2024
34 checks passed
@wcampbell0x2a wcampbell0x2a deleted the remove-filesystem-alloc-read-buffers branch April 14, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant