Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev and test CI does not run on forks #25

Closed
wcarhart opened this issue Oct 1, 2019 · 1 comment
Closed

Dev and test CI does not run on forks #25

wcarhart opened this issue Oct 1, 2019 · 1 comment
Assignees
@wcarhart
Labels
bug Something isn't working

Comments

@wcarhart
Copy link
Owner

wcarhart commented Oct 1, 2019

This line in .travis.yml prohibits CI from running from forks, since the default branch on most forks is master:

if [[ $TRAVIS_COMMIT_MESSAGE != *"NOTRAVIS"* && $TRAVIS_EVENT_TYPE == "pull_request" && $TRAVIS_PULL_REQUEST_BRANCH != "master" ]] ; then ...

Should be changed to remove $TRAVIS_PULL_REQUEST_BRANCH != "master".
@wcarhart wcarhart added the bug Something isn't working label Oct 1, 2019
@wcarhart wcarhart self-assigned this Oct 1, 2019
@wcarhart
Copy link
Owner Author

wcarhart commented Oct 2, 2019

Resolved with #28.

@wcarhart wcarhart closed this as completed Oct 2, 2019
@wcarhart wcarhart mentioned this issue Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wcarhart wcarhart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wcarhart