-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GearmanJob::setCompleteCallback() not working #3
Comments
Thanks for the thorough bug report, @vojta! Will take a look |
hey @vojta, I've made a change I think fixes the problem. Reopen if not. I don't have many example of task work (and the unit tests for this are pretty poor, trying to fix that too!) so if this still isn't quite right or you see any others, please let me know. Thanks again for the help here! |
Thank you! The testcase works, so you definitely fixed this one. But I'm still getting segfaults in real production code :( It's weird. I'll try to isolate this problem. Will, please, how are your gearman calls that you are using in production? If we use the same as you do, we might run in less bugs like this :) |
Ok, I'll reopen. Sorry Dude :( We're using Gearman jobs instead of tasks, so it's hitting different parts of the extension. Maybe it's trying to do several tasks in a row? Or the same task multiple times? I'll try to squeeze in some time to look at those, but if you could do the same (or try to narrow down) that'd be great! |
I think this issue is resolved well, I just created another issue that touches different callback. Closing. |
Hi,
I've just reproduced a problem with setCompleteCallback() on GearmanJob. The callback set by this method is not called on job completion, but setFailCallback is used instead. This is not an issue when using PHP 5.5 gearman extension, it works fine.
gearman_worker.php:
gearman_client.php:
To reproduce, just start the worker:
and run the client:
It runs OK on PHP 5.5:
Could you please help me with this? Thank you
The text was updated successfully, but these errors were encountered: