Add R version 3.3.2 to checks for download_no_libcurl. #35
Conversation
| @@ -165,7 +165,8 @@ available_port <- function(port) { | |||
| # 403 for HEAD requests. See | |||
| # https://stat.ethz.ch/pipermail/r-devel/2016-June/072852.html | |||
| download <- function(url, destfile, mode = "w") { | |||
| if (getRversion() == "3.3.0" || getRversion() == "3.3.1") { | |||
| if (getRversion() == "3.3.0" || getRversion() == "3.3.1" || | |||
There was a problem hiding this comment.
Do you mind changing it to just getRversion() >= "3.3.0"? I have a feeling that the issue isn't going to be fixed in R any time soon.
|
Thanks! |
|
@wch When do you plan to release a new version? Currently webshot::install_phantomjs() fails in R 3.3.2 with 403 |
|
@dhuebner it will probably be a few weeks before a new release. But until then you can install the development version using devtools. |
|
|
It will be a few more weeks. |
|
@wch What about an approximate date? :) January? February? |
|
I'm hoping by mid-January... although if my schedule magically clears up before then, I'll try to get it out sooner. |
|
Thanks, Winston. |
|
@dhuebner I just released a new version to CRAN. |
|
@wch Very cool thanks! |
For me (on OSX, R 3.3.2), this fixes the install / download problem referenced in #22.
Thank you for
webshot!