fix: no text watermark when original image has exif rotate 90 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
watermark with image mixed text should be fixed also |
wchaws
commented
Sep 29, 2022
| @@ -276,7 +276,7 @@ export class WatermarkAction extends BaseImageAction { | |||
| const gravityOpt = this.calculateMixedGravity(opt); | |||
| const wbt = await watermarkImg.toBuffer(); | |||
|
|
|||
| const metadata = await ctx.image.metadata(); | |||
| const metadata = withNormalSize(ctx.metadata); | |||
There was a problem hiding this comment.
@tingxin Here is the mixedWaterMark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix: #141
Description of changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.