migration to androidx once more :) #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wching
reviewed
Oct 6, 2019
...agerindicator/src/main/java/com/rbrooks/indefinitepagerindicator/IndefinitePagerIndicator.kt
Outdated
Show resolved
Hide resolved
.../com/rbrooks/indefinitepagerindicatorsample/rtlViewPagerSample/RTLViewPagerSampleFragment.kt
Outdated
Show resolved
Hide resolved
...n/java/com/rbrooks/indefinitepagerindicatorsample/viewPagerSample/ViewPagerSampleFragment.kt
Outdated
Show resolved
Hide resolved
sample/src/test/java/com/rbrooks/indefinitepagerindicatorsample/ExampleUnitTest.kt
Outdated
Show resolved
Hide resolved
...n/java/com/rbrooks/indefinitepagerindicatorsample/viewPagerSample/ViewPagerSampleFragment.kt
Outdated
Show resolved
Hide resolved
|
i've updated all the points of your feedback @wching |
|
Testing today and then if nothing is off, I'll merge it @kibotu! :) |
|
yea let me know :) it's a cool project which i personally believe to be the best long lists dot indicators |
wching
reviewed
Oct 23, 2019
| implementation "androidx.appcompat:appcompat:1.1.0" | ||
| implementation "androidx.appcompat:appcompat-resources:1.1.0" | ||
| implementation 'androidx.recyclerview:recyclerview:1.1.0-beta04' | ||
| implementation 'com.google.android.material:material:1.1.0-alpha10' |
There was a problem hiding this comment.
why are we adding the material alpha here?
and I think we should stick to stable versions for the sake of everybody :)
| @@ -378,7 +424,7 @@ class IndefinitePagerIndicator @JvmOverloads constructor( | |||
| private fun getMostVisibleChild(): View? { | |||
| var mostVisibleChild: View? = null | |||
| var mostVisibleChildPercent = 0f | |||
| for (i in recyclerView?.layoutManager?.childCount!! - 1 downTo 0) { | |||
| for (i in (recyclerView?.layoutManager?.childCount ?: 0 - 1).coerceAtLeast(0) downTo 0) { | |||
| private fun setIntermediateSelectedItemPosition(mostVisibleChild: View?) { | ||
| with(recyclerView?.findContainingViewHolder(mostVisibleChild)?.adapterPosition!!) { | ||
| private fun setIntermediateSelectedItemPosition(mostVisibleChild: View) { | ||
| with(recyclerView?.findContainingViewHolder(mostVisibleChild)?.adapterPosition) { |
There was a problem hiding this comment.
we could remove the with clause and use let instead. Because we are just using this everywhere that way we could also do nothing if not adapter position exists. What do you think?
|
@kibotu any news? |
Merged
|
Closing as #39 was quicker addressing concerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated