Ensure non pattern shorthand props are checked for reserved words (ba…

…bel#479)
wcjohnson · May 10, 2017 · 7c56c24 · 7c56c24
1 parent 67db275
commit 7c56c24
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 1 deletion.
diff --git a/src/parser/expression.js b/src/parser/expression.js
@@ -884,8 +884,9 @@ pp.parseObjectProperty = function (prop, startPos, startLoc, isPattern, refShort
   }
 
   if (!prop.computed && prop.key.type === "Identifier") {
+    this.checkReservedWord(prop.key.name, prop.key.start, true, true);
+
     if (isPattern) {
-      this.checkReservedWord(prop.key.name, prop.key.start, true, true);
       prop.value = this.parseMaybeDefault(startPos, startLoc, prop.key.__clone());
     } else if (this.match(tt.eq) && refShorthandDefaultPos) {
       if (!refShorthandDefaultPos.start) {

diff --git a/test/fixtures/es2015/shorthand/1/actual.js b/test/fixtures/es2015/shorthand/1/actual.js
@@ -0,0 +1 @@
+var x = ({ const });
diff --git a/test/fixtures/es2015/shorthand/1/options.json b/test/fixtures/es2015/shorthand/1/options.json
@@ -0,0 +1,3 @@
+{
+  "throws": "const is a reserved word (1:11)"
+}
diff --git a/test/fixtures/es2015/shorthand/2/actual.js b/test/fixtures/es2015/shorthand/2/actual.js
@@ -0,0 +1 @@
+({ get, this, if });
diff --git a/test/fixtures/es2015/shorthand/2/options.json b/test/fixtures/es2015/shorthand/2/options.json
@@ -0,0 +1,3 @@
+{
+  "throws": "this is a reserved word (1:8)"
+}