Fix: allow options to be optional when monkey patching escope.analyze (…

…fixes babel#470). (babel#484)
wcjohnson · Jun 8, 2017 · 1aedb95 · 1aedb95
1 parent a8003c0
commit 1aedb95
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -62,6 +62,7 @@ function monkeypatch(modules) {
 
   var analyze = escope.analyze;
   escope.analyze = function (ast, opts) {
+    opts = opts || {};
     opts.ecmaVersion = eslintOptions.ecmaVersion;
     opts.sourceType = eslintOptions.sourceType;
     if (eslintOptions.globalReturn !== undefined) {

diff --git a/test/babel-eslint.js b/test/babel-eslint.js
@@ -1,6 +1,7 @@
 var assert      = require("assert");
 var babelEslint = require("..");
 var espree      = require("espree");
+var escope      = require("escope");
 var util        = require("util");
 var unpad       = require("dedent");
 
@@ -85,6 +86,16 @@ function parseAndAssertSame(code) {
 }
 
 describe("babylon-to-esprima", () => {
+  describe("compatibility", () => {
+    it("should allow ast.analyze to be called without options", function() {
+      var esAST = babelEslint.parse("`test`");
+
+      assert.doesNotThrow(() => {
+        escope.analyze(esAST);
+      }, TypeError, "Should allow no options argument.");
+    });
+  });
+
   describe("templates", () => {
     it("empty template string", () => {
       parseAndAssertSame("``");