Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for package.json in parent directories #47

Open
RedHatter opened this issue Nov 22, 2018 · 4 comments
Open

Search for package.json in parent directories #47

RedHatter opened this issue Nov 22, 2018 · 4 comments

Comments

@RedHatter
Copy link

Both yarn and npm will search for a package.json in parent directories if not found in the cwd. Yalc should follow this same practice.

Say I'm in myproject/src, yarn build will execute fine but yalc push will throw Could not read myproject/src/package.json.

@wclr
Copy link
Owner

wclr commented Nov 22, 2018

I don't get the rationale for this? Not sure why the npm/yarn do this?

@RedHatter
Copy link
Author

RedHatter commented Nov 22, 2018

So that if your doing things deep inside of your source tree you don't have to cd all the way back to the root to build, then cd all the way back down to continue.

@wclr
Copy link
Owner

wclr commented Nov 22, 2018

Ok, will add ASAP, if you want to contribute it can be done /src/index.ts readPackageManifest No... it will be more complicated. ;)

aleclarson added a commit to aleclarson/yalc that referenced this issue Dec 30, 2018
Yalc now looks for the nearest ancestor that contains a package.json file.

I also did some tidying up!

Fixes wclr#47
@aleclarson
Copy link
Contributor

This will be fixed once #62 is merged. 🎉

aleclarson added a commit to aleclarson/yalc that referenced this issue Dec 30, 2018
Yalc now looks for the nearest ancestor that contains a package.json file.

I also did some tidying up!

Fixes wclr#47
aleclarson added a commit to aleclarson/yalc that referenced this issue Dec 30, 2018
Yalc now looks for the nearest ancestor that contains a package.json file.

I also did some tidying up!

Fixes wclr#47
aleclarson added a commit to aleclarson/yalc that referenced this issue Jan 11, 2019
Yalc now looks for the nearest ancestor that contains a package.json file.

I also did some tidying up!

Fixes wclr#47
aleclarson added a commit to aleclarson/yalc that referenced this issue Jan 11, 2019
Yalc now looks for the nearest ancestor that contains a package.json file.

I also did some tidying up!

Fixes wclr#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants