Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HalApiClientBuilder and HalResponseRendererBuilder #25

Merged
merged 17 commits into from
Jan 7, 2022

Conversation

feffef
Copy link
Member

@feffef feffef commented Jan 7, 2022

HalApiClient and HalResponseRenderer already contained too many overloads of their create methods, and further overloads would be required for additional customisations without breaking backwards compatibility

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #25 (be518a8) into develop (45adc39) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          122       125    +3     
  Lines         3566      3636   +70     
  Branches       258       263    +5     
=========================================
+ Hits          3566      3636   +70     
Impacted Files Coverage Δ
...avan/rhyme/api/common/RequestMetricsCollector.java 100.00% <ø> (ø)
...van/rhyme/api/server/VndErrorResponseRenderer.java 100.00% <ø> (ø)
...yme/impl/client/http/HttpUrlConnectionSupport.java 100.00% <ø> (ø)
...me/impl/reflection/CompositeHalApiTypeSupport.java 100.00% <ø> (ø)
...hyme/impl/reflection/HalApiTypeSupportAdapter.java 100.00% <ø> (ø)
.../testing/client/AbstractHalResourceLoaderTest.java 100.00% <ø> (ø)
...in/java/io/wcm/caravan/rhyme/api/RhymeBuilder.java 100.00% <100.00%> (ø)
.../io/wcm/caravan/rhyme/api/client/HalApiClient.java 100.00% <100.00%> (ø)
.../caravan/rhyme/api/client/HalApiClientBuilder.java 100.00% <100.00%> (ø)
...van/rhyme/api/server/AsyncHalResponseRenderer.java 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45adc39...be518a8. Read the comment docs.

@feffef feffef merged commit 29b1654 into develop Jan 7, 2022
@feffef feffef deleted the feature/additional-builders branch January 8, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant