Upgrade to spring boot 3 #47

ckumpe · 2023-09-06T11:03:38Z

This PR updates the rhyme spring integration to Spring Boot 3

feffef · 2023-09-08T10:37:12Z

.../spring-hypermedia/src/test/java/io/wcm/caravan/rhyme/spring/impl/SpringErrorHandlingIT.java

@@ -149,10 +149,12 @@ void should_extract_status_code_from_NoHandlerFoundException() {

    String nonExistingUrl = baseUri + "/foo/bar";

-    HalResponse errorResponse = getResponseFromCaughtClientException(
-        (er) -> client.getRemoteResource(nonExistingUrl, ErrorThrowingResource.class));
+    ErrorThrowingResource errorResource = client.getRemoteResource(nonExistingUrl, ErrorThrowingResource.class);


why can't this test use getResponseFromCaughtClientException any more? I didn't spot any difference in the assertions

Because the 404 is returned with another content-type "application/json" and not "application/vnd.error".
I decided that this is acceptable for simple unmapped URLs. Or do you think It's a regression?

Perhaps I'll refactor the code a little bit to spot this difference more clearly.

Ah, okay I missed that.

Then this is indeed a minor regression. The goal for the spring integration is that for as many errors as possible a full vnd.error response is being returned.

This is what the VndErrorHandlingControllerAdvice should take care of.

The previous solution was already a bit fragile, as it required some additional configuration in the application properties:

caravan-rhyme/examples/spring-hypermedia/src/main/resources/application.yml

Line 3 in 4b2f562

spring:

This did already change with some minor spring 2.x. update a while ago.

I guess if you start one of the spring examples now, and call a non-existant URL like /foo/bar, you'll probably see a default 404 JSON response from the spring framework now, instead of the custom vnd.error responses you get for any other exceptions.

This is something we would want to avoid, and make sure these HandlerNotFoundExceptions also are treated as other framework exceptions (i.e. caught and rendered by the VndErrorHandlingControllerAdvice )

If it's too much work to get this working again however, it's not essential

I even managed to restore the expected error handling with new Spring version.
That obsoletes this question.

Thanks @feffef to spot this issue again.