Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asset.ignore option #23

Merged
merged 2 commits into from Oct 30, 2019
Merged

Add asset.ignore option #23

merged 2 commits into from Oct 30, 2019

Conversation

samuelmeuli
Copy link
Contributor

Hi,

Would you be open to an ignore options for assets? This would e.g. simplify copying entire directories except for a few files, as it wouldn't be required to write a complicated glob pattern for that.

The value of the ignore option can simply be passed to functions of the glob module (see https://github.com/isaacs/node-glob#options).

@ifahrentholz
Copy link
Member

Thanks for your pull request.
The ignore option is working fine I've checked it manually..
Since we want automatic tests for these kind of changes an update of our TestCase script seems to be necessary.

@samuelmeuli
Copy link
Contributor Author

I've added a test.

@ifahrentholz ifahrentholz merged commit abda434 into wcm-io-frontend:master Oct 30, 2019
@ifahrentholz
Copy link
Member

Thanks for your contribution :)

@samuelmeuli samuelmeuli deleted the ignore-option branch October 30, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants