Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide a versioned library #82

Closed
luyatshimbalanga opened this issue Jul 19, 2020 · 2 comments
Closed

Please provide a versioned library #82

luyatshimbalanga opened this issue Jul 19, 2020 · 2 comments

Comments

@luyatshimbalanga
Copy link

luyatshimbalanga commented Jul 19, 2020

Hello,
I am a Fedora contributor aiming to package partio. The review process suggested to include the versionned library on src/lib/CMakeLists.txt using the following line:

set_target_properties(partio PROPERTIES
    OUTPUT_NAME partio POSITION_INDEPENDENT_CODE ON
    VERSION ${CMAKE_PROJECT_VERSION}
    SOVERSION 1 
)

Edit: correct line.
Hopefully, you will provide the suggestion on the next release.
Thanks in advance.

@davvid
Copy link
Member

davvid commented Jul 22, 2020

Thanks for the sug @luyatshimbalanga -- yes, this would be good to do.

@danfe
Copy link

danfe commented Dec 9, 2020

For ${CMAKE_PROJECT_VERSION} expansion to work, project() should be called with VERSION argument in the top-level CMakeLists.txt.

@davvid davvid closed this as completed in f04e122 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants