setImmediate instead of nextTick for node >=0.10 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdavidw
added a commit
that referenced
this pull request
Jul 30, 2013
setImmediate instead of nextTick for node >=0.10
|
Excellent catch and thanks for the clean commit |
wdavidw
added a commit
that referenced
this pull request
Jul 30, 2013
|
A new version is published with your changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're supposed to use
setImmediatein node >=0.10 instead ofprocess.nextTick. The test cases were only passing because none of them tested on more documents thanprocess.maxTickDepth(by default 1000). If you run on more documents than that, it crashes withRangeError: maximum call stack size exceeded.I artificially lowered
process.maxTickDepthin one of the test cases to generate a failing test case, then changed all instances ofprocess.nextTickto usesetImmediatewhere available and verified that the test cases are passing again.I didn't submit any of the compiled js because my version of coffee-script is different than your's so there were a lot of diffs that were just white noise.