Use standard path for oauth callback. Update docs, including upgrade steps. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 25, 2015 12:14
- fail early and often - use #fetch - raise RestClient failure (was hiding invalid callback uri messages and similar) - use existing variables instead of referencing ENV multiple locations (especially since there were typos) - extract github_oauth_callback_url, github_oauth_authorize_url
| ### Set ENV variables | ||
|
|
||
| This app loads ENV variables from the (uncommitted) env.rb file. | ||
| - Copy "env.example.rb" to "env.rb" and |
|
👍 looks great!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar)
(especially since there were typos)