Add new shortcode attribute to limit no. of items shown #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This - or some global option in the settings - would be very useful. Hope it gets implemented into the core of the plugin soon! |
|
As the default Thanks for the pull request 👍 |
|
@tareq1988 done 👍 |
tareq1988
added a commit
that referenced
this pull request
Aug 24, 2018
= v1.4 (25 August, 2018) = * **New:** Added new shortcode attribute (<code>items</code>) to limit no. of items shown. [#59](https://github.com/tareq1988/wedocs-plugin/pull/59/files) * **New:** Added a new filter <code>wedocs_email_feedback_to</code> for outgoing mail to address. [#63](#63) * **New:** Added theme wrapper support. Now developers will be able to put dynamic start and end divs and tags in the <code>single-docs.php</code> template. * **New:** Show 3rd level doc in the admin UI builder. * **New:** Added automatic anchor tags in docs for <code>h2</code> and <code>h3</code> tags. Bookmarking is now very easy! Thanks to [anchorjs](https://github.com/bryanbraun/anchorjs/). * **Fix:** Bug with quotes in the doc title. [#66](#66) * **Improved:** Flush rewrite rules after plugin activates. Fixes the long time permalink issues with 404. * **Improved:** Disable page scrolling when the feedback modal is open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having one attribute to limit no. of items shown under a section is a good idea. Because if one section has 10 docs and another section has 3, that doesn't look good (http://www.clipular.com/c/4600533885911040.png?k=SLjoisnTJ2GYw0gHKpN7z3pdmtU). If we can limit maximum items shown to 3, the UI wise, that will look good.