-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP Read implementation #41
base: master
Are you sure you want to change the base?
Conversation
This is now fully working:
feedback on the implementation is more than welcome |
lgtm! works fine with real examples. only small problem is that the following test fails, probably because of some custom error change;
|
thanks for reviewing it, mate. this test is failing on the main branch as well, I'll fix it with a similar scenario. |
the |
any updated on this? |
I think in that case this should be handled in the original go-ens repo. It's surely unrelated with the current PR. All good for me. |
@pikonha Thanks for putting this together, was looking for an implementation just like this to help with x-chain reads for a project of mine. Anything I can do to help get it merged? |
@dneilroth it's pretty much done from my end tbh, just waiting for the review and approval. |
CCIP Read implementation
Description
This pull request adds the CCIP-Read support to the Go-ENS library. This function enables users to read data from offchain data sources that follow the EIP-3668 standard.
These additions enhance the versatility and utility of the Go-ENS library by enabling seamless interaction with contracts and providing efficient domain resolution capabilities. The implementation aligns with the library's objective of comprehensive support for Ethereum Name Service (ENS) operations.
How it works
jesse.cd.id
(externally handled by Coinbase's Offchain Resolver)addr(namehash)
orresolve(labelhash, encodedArgs)
function on the contract which reverts withOffchainLookup
as described on the EIP-3668sender
andcalldata
as arguments following the Gateway InterfacecallbackFunction
is then called with the API's response and theextraData
to validate the authenticity of the dataRelated Issue
Issue #38
PR #40
Changes
Changes to Core Features:
Additional Notes
I'm working on the CCIP Read implementation for the other features such as reading text, multicoin addresses, and
contenthash
.The Subdomain resolution PR was used as a starting point for this implementation, which enables this PR to handle both, CCIP-Read and subdomain resolution. They have been decoupled to make the review process easier.
Cheers from the Blockful team 👋🏼